[
https://issues.apache.org/jira/browse/SLING-10914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls updated SLING-10914:
-------------------------------
Description:
The converter does attempt to (re-)calculate the package type (application,
content, mixed) as part of creating the converted packages. However, it doesn't
take the targets of the filters into account when determining the type. As
such, it is possible that e.g. a package containing a filter targeting apps
would end up being classified as being of type content. Furthermore, it when
looking into the content, it doesn't take into account if the content is
covered by filters - ie., it doesn't really check if the content would be
ignored by vault.
Given that it is hard to know what vault will install or not, it might not be
possible to fix the second issue - however, it should be possible to at least
look at the filters and take their targets into account (as pathes) when
(re-)calculating the package type.
was:
As of now, the package (re)calculation being performed is done on the basis of
package contents.
Instead what it should be calculated on is the package filter. Because an empty
"nuke filter" can be used as well, to clear out paths.
Therefore to avoid collision, the package filters should be used as leading
indicator.
> CpConverter - package type calculation should take filters into account
> -----------------------------------------------------------------------
>
> Key: SLING-10914
> URL: https://issues.apache.org/jira/browse/SLING-10914
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
> Affects Versions: Content-Package to Feature Model Converter 1.1.10
> Reporter: Niek Raaijmakers
> Assignee: Niek Raaijmakers
> Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.1.12
>
>
> The converter does attempt to (re-)calculate the package type (application,
> content, mixed) as part of creating the converted packages. However, it
> doesn't take the targets of the filters into account when determining the
> type. As such, it is possible that e.g. a package containing a filter
> targeting apps would end up being classified as being of type content.
> Furthermore, it when looking into the content, it doesn't take into account
> if the content is covered by filters - ie., it doesn't really check if the
> content would be ignored by vault.
> Given that it is hard to know what vault will install or not, it might not be
> possible to fix the second issue - however, it should be possible to at least
> look at the filters and take their targets into account (as pathes) when
> (re-)calculating the package type.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
