joerghoh opened a new pull request #53:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/53


   Currently we are quite short in terms of metrics, which allow us to observe 
some basic numbers for the ResourceResolver. This PR adds 3 basic metrics:
   
   * the number of aliases
   * the number of vanity paths
   * the number of unclosed resourceResolvers
   
   The implementation is straight forward, there is a single 
```ResourceResolverMetrics``` service, which either registers the Gauge 
services into OSGI or directly uses the Counter from Sling Commons Metrics. 
Basic test coverage for the ```ResourceResolverMetrics``` is provided, but I 
haven't augmented the existing test cases with validations, that their 
operations properly reflect in the metrics.
   
   I tested this PR locally with my AEM instance, and all 3 metrics are 
reflected as JMX objects:
   * 
org.apache.sling.resourceresolver:name=unclosedResourceResolvers,type=Metrics
   * org.apache.sling.resourceresolver:name=numberOfVanityPaths,type=Metrics
   * org.apache.sling.resourceresolver:name=numberOfAliases,type=Metrics
   
   as well as Metrics (flat in the sling namespace):
   * sling:numberOfAliases
   * sling:numberOfVanityPaths
   * sling:unclosedResourceResolvers
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to