stefanseifert commented on a change in pull request #4:
URL: 
https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/4#discussion_r760906679



##########
File path: 
src/main/java/org/apache/sling/models/jacksonexporter/impl/JacksonExporter.java
##########
@@ -124,6 +120,9 @@ public boolean isSupported(@NotNull Class<?> clazz) {
         }
     }
 
+    @Reference(name = "moduleProvider", service = ModuleProvider.class,
+            cardinality = ReferenceCardinality.MULTIPLE, policy = 
ReferencePolicy.DYNAMIC,
+            bind = "bindModuleProvider", unbind = "unbindModuleProvider")
     protected void bindModuleProvider(final ModuleProvider moduleProvider, 
final Map<String, Object> props) {

Review comment:
       to be handled in https://issues.apache.org/jira/browse/SLING-10964

##########
File path: 
src/main/java/org/apache/sling/models/jacksonexporter/impl/JacksonExporter.java
##########
@@ -22,17 +22,16 @@
 import java.io.StringWriter;
 import java.util.Map;
 
-import org.apache.felix.scr.annotations.Component;
-import org.apache.felix.scr.annotations.Reference;
-import org.apache.felix.scr.annotations.ReferenceCardinality;
-import org.apache.felix.scr.annotations.ReferencePolicy;
-import org.apache.felix.scr.annotations.Service;
 import org.apache.sling.commons.osgi.Order;

Review comment:
       to be handled in https://issues.apache.org/jira/browse/SLING-10964




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to