stefanseifert opened a new pull request #5: URL: https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/5
this PR does not contain any unit tests because atm all exporter tests are ITs in a separate module https://github.com/apache/sling-org-apache-sling-models-integration-tests in the existing code the order of ModuleProvider references was not covered, i planned to add a test case for this. but looking deeper into the code turned out that's not that easy - and probably not required. what a ModuleProvider is doing is registering a Jackson "Module" to the ObjectMapper, and this module registry with all their tiny parts (like lists of serializers etc.) has a very complex structure. and each module usually registers to a different class and there usually should not be a conflict if the order is different. i validated that the integration test cover the case if any of the existing modul provider implementations is missing, and they pass with this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
