stefanseifert commented on a change in pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/5#discussion_r763737562
##########
File path: pom.xml
##########
@@ -181,6 +181,7 @@
<artifactSet>
<includes>
<include>org.apache.jackrabbit:*</include>
+ <include>com.google.guava:*</include>
Review comment:
oh - relocating does not work because it's references not from our code
here but from jackrabbit oak itself.
does it then help at all including it without relocating?
##########
File path: pom.xml
##########
@@ -181,6 +181,7 @@
<artifactSet>
<includes>
<include>org.apache.jackrabbit:*</include>
+ <include>com.google.guava:*</include>
Review comment:
oh - relocating does not work because it's referenced not from our code
here but from jackrabbit oak itself.
does it then help at all including it without relocating?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
