paul-bjorkstrand commented on a change in pull request #75:
URL: https://github.com/apache/sling-site/pull/75#discussion_r769024819
##########
File path: src/main/jbake/content/documentation/bundles/models.md
##########
@@ -55,6 +57,35 @@ Constructor injection is also supported (as of Sling Models
1.1.0):
Because the name of a constructor argument parameter cannot be detected via
the Java Reflection API a `@Named` annotation is mandatory for injectors that
require a name for resolving the injection.
+Constructors may use any visibility modifier (as of Sling Models 1.5.0):
Review comment:
Will make the change and push a bit later today. Regarding method
injection for concrete models - I could see that as an enhancement. I'll add a
new ticket for that feature
Also, I think the code could use a little attention in
`ModeAdapterlFactory`(I REALLY want to refactor it, but just need the time to
sit down and understand everything).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
