Gabiesfat commented on pull request #50:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/50#issuecomment-996360417


   > @Gabiesfat - that was my point, this test case shows that for an empty 
path you don't get a null result. It's possible that the unit tests are 
incorrect somehow. Maybe it's best that you debug your scenario with the empty 
path, see what code paths are triggered, and reproduce them with a test case.
   > 
   > If you have problems with the test case I can definitely help, but we need 
to understand the failure scenario first.
   
   Apparently the issue was at [0] the resolver could also resolve to null 
resource and the same scenario has not been replicated in the test you 
mentioned. I have added a test which replicates the same scenario and the same 
fails without my  fix. Please have a look at it let me know your thoughts.
   [0]: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L145


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to