cziegeler commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/1#discussion_r780910195
##########
File path: src/main/java/org/apache/sling/commons/metrics/Gauge.java
##########
@@ -34,14 +43,12 @@
* };
* </code></pre>
*
- * <p> A Gauge instance should be registered with OSGi ServiceRegistry with
{@code Gauge#NAME} set
- * to Gauge name. Then the Gauge instance would be registered with
MetricService via whiteboard
- * pattern
+
*
* @param <T> the type of the metric's value
*/
@ConsumerType
-public interface Gauge<T> {
+public interface Gauge<T> extends Metric {
Review comment:
I fear we need to create a new interface - Gauge is right now a
ConsumerType - this new gauge should be a ProviderType. As Metric is a
ProviderType Gauge can't extend Metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
