[ 
https://issues.apache.org/jira/browse/SLING-10967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472998#comment-17472998
 ] 

Joerg Hoh commented on SLING-10967:
-----------------------------------

PR: https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/1

> Improve Gauge support in metrics
> --------------------------------
>
>                 Key: SLING-10967
>                 URL: https://issues.apache.org/jira/browse/SLING-10967
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons
>    Affects Versions: Commons Metrics 1.2.8
>            Reporter: Joerg Hoh
>            Priority: Major
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Currently Sling Metrics only support Gauges via the whiteboard approach (see 
> SLING-5966).
> To leverage gauges you have to register a gauge instance by yourself using 
> the OSGI Framework API and also its whole livecycle. The Sling MetricsService 
> should be able to handle this for you as well like it does for the other 
> metric types (e.g. counter).
> I propose to extend the MetricsService by a new method:
> {code}
> Gauge<T> registerGauge (String name, Supplier<T> supplier);
> {code}
> which registers a Gauge which on every request to {{getValue()}} calls the 
> provided supplier. In most cases the returned Gauge object is not used, but 
> it is returned for consistency with other methods of the MetricsService.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to