On Tue, Apr 26, 2011 at 10:46 AM, Carsten Ziegeler <[email protected]> wrote: > Justin Edelson wrote: >> But the taglib isn't exported by the environment - the taglib in this case >> is the Jakarta (now Tomcat) JSTL implementation, repackaged into an OSGi >> bundle and shipped as part of our commercial product. >> >> The 'nasty' bits are in the Java code generated by the WebLogic JSP >> compiler. Arguably, this is a bug in WebLogic, but I doubt Oracle is going >> to change this anytime soon. So I'm suggesting we accommodate their >> implementation. >> >> The decision to use the original JspFactory or the Sling JspFactory has to >> be done inside the tag logic, not around it as you're suggesting - in this >> case, we only want to use the original if the context attribute is pointing >> to another context. If it is an internal import, the Sling factory is fine. >> > Ah right, I see - now what about providing wrappers for the servlet > context object for other contexts than the Sling one? > We could return a wrapper request dispatcher which switches the factory.
We'll have to wrap the Sling servlet config / servlet context as well. Updated patch here: http://codereview.appspot.com/4437073 Justin > > Regards > Carsten > -- > Carsten Ziegeler > [email protected] >
