[ 
https://issues.apache.org/jira/browse/SLING-11072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Niek Raaijmakers updated SLING-11072:
-------------------------------------
    Description: 
We need to introduce a command line argument in the CPConverter.

The toggle should enables us to use the source package type when determining 
package types of generated content packages. It should be on by default.

 

We can then disable / overrule this by passing in false from the command line.

  was:
The converter does attempt to (re-)calculate the package type (application, 
content, mixed) as part of creating the converted packages. However, it doesn't 
take the targets of the filters into account when determining the type. As 
such, it is possible that e.g. a package containing a filter targeting apps 
would end up being classified as being of type content. Furthermore, it when 
looking into the content, it doesn't take into account if the content is 
covered by filters - ie., it doesn't really check if the content would be 
ignored by vault. 

Given that it is hard to know what vault will install or not, it might not be 
possible to fix the second issue - however, it should be possible to at least 
look at the filters and take their targets into account (as pathes) when 
(re-)calculating the package type.


> Introduce command line argument for CPConverter to toggle the use of source 
> package type for package type calculation.
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-11072
>                 URL: https://issues.apache.org/jira/browse/SLING-11072
>             Project: Sling
>          Issue Type: Bug
>          Components: Content-Package to Feature Model Converter
>    Affects Versions: Content-Package to Feature Model Converter 1.1.10
>            Reporter: Niek Raaijmakers
>            Assignee: Niek Raaijmakers
>            Priority: Minor
>             Fix For: Content-Package to Feature Model Converter 1.1.12
>
>
> We need to introduce a command line argument in the CPConverter.
> The toggle should enables us to use the source package type when determining 
> package types of generated content packages. It should be on by default.
>  
> We can then disable / overrule this by passing in false from the command line.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to