[ 
https://issues.apache.org/jira/browse/SLING-10952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479011#comment-17479011
 ] 

Dan Klco commented on SLING-10952:
----------------------------------

Nice catch [~cziegeler]. I can fix this as it was not an intended change, but 
I'm a little concerned the test doesn't pick up the issue. 

There's no JavaDoc for Operation.asRepoInitString(), however all of the other 
operations follow the convention of using an OS-agnostic line separator at the 
end of the statement and this would seem like a reasonable safety measure for 
generating scripts.

To catch this in the future, I was thinking to create a new issue to clarify 
the behavior in the JavaDoc and add a test to verify the behavior. Make sense?

> Repoinit - Support Whitespace in Group IDs
> ------------------------------------------
>
>                 Key: SLING-10952
>                 URL: https://issues.apache.org/jira/browse/SLING-10952
>             Project: Sling
>          Issue Type: Improvement
>          Components: Repoinit
>    Affects Versions: Repoinit Parser 1.6.10
>            Reporter: Dan Klco
>            Assignee: Dan Klco
>            Priority: Major
>             Fix For: Repoinit Parser 1.6.12
>
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Currently, Repoinit does not support creating or managing groups with 
> whitespace in the principal name as the group name is treated as a string and 
> does not support being quoted.
> This works for system-managed groups as these can be created with names not 
> containing whitespace, however when synchronizing groups from external 
> systems, for example using the Oak OAuth integration, the source system could 
> provide group names containing whitespace which cannot be managed or 
> pre-created via Repoinit.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to