kwin commented on a change in pull request #7:
URL:
https://github.com/apache/sling-jspc-maven-plugin/pull/7#discussion_r794913806
##########
File path: pom.xml
##########
@@ -157,14 +174,14 @@
<dependency>
<groupId>org.apache.felix</groupId>
<artifactId>org.apache.felix.framework</artifactId>
- <version>7.0.1</version>
- <scope>provided</scope>
+ <version>7.0.3</version>
+ <scope>compile</scope>
Review comment:
this is huge and not necessary in all cases, isn't there the possibility
to make the Mojo run without it? It is not really expected that a JSP Compiler
Mojo always need this dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
