karlpauls commented on a change in pull request #7:
URL:
https://github.com/apache/sling-jspc-maven-plugin/pull/7#discussion_r794920938
##########
File path: pom.xml
##########
@@ -157,14 +174,14 @@
<dependency>
<groupId>org.apache.felix</groupId>
<artifactId>org.apache.felix.framework</artifactId>
- <version>7.0.1</version>
- <scope>provided</scope>
+ <version>7.0.3</version>
+ <scope>compile</scope>
Review comment:
I guess you could force people to add it manually - however, I find that
more unexpected than having a bit more download. Furthermore, the difference is
26mb dependencies to 23mb dependencies. Not sure it is worthwhile to make users
jump through hoops just to save them some 3mb download (especially given the
amount of downloading going on anyways).
Anyways, I'd say this fixes the bug for now - if we want to change it we can
do it in an improvement issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
