bosschaert commented on a change in pull request #11:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-core/pull/11#discussion_r799349636
##########
File path:
src/main/java/org/apache/sling/scripting/core/impl/bundled/AbstractBundledRenderUnit.java
##########
@@ -126,7 +124,7 @@ public BundleContext getBundleContext() {
}
}
}
- return null;
+ return result;
Review comment:
It's a little bit a matter of taste IMHO. I personally find it easier to
read when a method returns straight away when it can, rather than reading
through the rest of the method to see that nothing else is happening before it
returns at the end.
So therefore my preference would be to keep the 2 return statements as we
have them now.
If you feel strongly about this one we can address it in a subsequent commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
