cziegeler commented on a change in pull request #34:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/34#discussion_r803674732
##########
File path:
src/main/java/org/apache/sling/models/impl/injectors/OSGiServiceInjector.java
##########
@@ -206,7 +206,7 @@ public void onDisposed() {
for (ServiceReference<?> ref : refs) {
try {
context.ungetService(ref);
- } catch (IllegalStateException | IllegalArgumentException
| NullPointerException exception) {
+ } catch (IllegalStateException exception) {
log.error("Failed to unget service ref {}", ref,
exception);
Review comment:
I haven't looked at what this code is doing, just commenting on catching
such exceptions and logging
OSGi cleans up service and service references on bundle events.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
