Committed a change so that all bundles are preloaded. I'd like to optimize the implementation a bit more, but I thought this was good enough to get some feedback.
Thanks, Justin On Thu, May 12, 2011 at 9:29 AM, Justin Edelson <[email protected]> wrote: > Well, I was trying to keep in the spirit of lazy loading and I see I > actually messed up by making preload.bundles default to "en" (had > intended to keep it blank by default). > > Proxies seem like overkill to me and you lose the automatic > notification provided by services registration/unregistration - I'd > rather just register all available ResourceBundles on startup. WDYT? > > Justin > > On Thu, May 12, 2011 at 12:39 AM, Carsten Ziegeler <[email protected]> > wrote: >> Isn't there maybe a better way which doesn't require a configuration? >> It seems a little bit strange to me that resource bundles are only >> registered if they are either configured or loaded by some other means. >> I would rather expect to get the resource bundle as a service in all cases. >> >> So maybe we should separate registering from the actual loading and >> maybe just register proxies or something? >> >> Regards >> Carsten >> >>> Author: justin >>> Date: Wed May 11 19:46:32 2011 >>> New Revision: 1102051 >>> >>> URL: http://svn.apache.org/viewvc?rev=1102051&view=rev >>> Log: >>> SLING-2061 / SLING-2062 - preloading configured set of resource bundles and >>> registering each individual resource bundle as a service >>> >>> Modified: >>> >>> sling/trunk/contrib/extensions/i18n/src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java >>> >>> sling/trunk/contrib/extensions/i18n/src/main/resources/OSGI-INF/metatype/metatype.properties >> >> >> -- >> Carsten Ziegeler >> [email protected] >> >
