stefanseifert commented on pull request #13:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13#issuecomment-1065120152


   this looks much better, thanks.
   
   > I'd like to hear more about 'c)', it seems like you may be saying that you
   > want to defer all Content-Loading until all of the configured
   > 'defaultRequireImportProviders' are satisfied?  I'm not sure that is better
   > than 'b)' since you may encounter a situation where you are waiting for
   > something that never arrives and is never used.
   
   yes, i still would prefer combining this with 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12 to 
get rid if those warnings as well - in case they affect the built-in content 
readers.
   
   i do not get the point why we should wait without success for one of the 4 
built-in content readers when we introduce a hardcoded dependency. they are 
even the default ones for the directive introduced here, and 99% of all bundles 
which are already out there will rely on this default config. theoretically 
they could be moved elsewhere in the future, but in practice they are there and 
in use - until someone forcefully disables them from outside the bundle.
   
   what's the downside of making those 4 mandatory for the whiteboard to become 
active?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to