rombert commented on a change in pull request #15:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/15#discussion_r825738157
##########
File path: src/main/java/javax/xml/parsers/FactoryFinder.java
##########
@@ -159,7 +159,8 @@ static Object find(String factoryId, String
fallbackClassName)
}
static class ConfigurationError extends Error {
- private Exception exception;
+
+ private Exception exception;
Review comment:
nit: please remove this whitespace-only change
##########
File path:
src/main/java/org/apache/sling/xss/impl/webconsole/XSSProtectionAPIWebConsolePlugin.java
##########
@@ -58,7 +58,7 @@
)
public class XSSProtectionAPIWebConsolePlugin extends HttpServlet {
- private static final Logger LOGGER =
LoggerFactory.getLogger(XSSProtectionAPIWebConsolePlugin.class);
+ private static final Logger LOGGER =
LoggerFactory.getLogger(XSSProtectionAPIWebConsolePlugin.class);
Review comment:
nit: please remove this whitespace-only change
##########
File path: pom.xml
##########
@@ -273,11 +273,11 @@
<scope>provided</scope>
</dependency>
<dependency>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-lang3</artifactId>
- <version>3.6</version>
- <scope>provided</scope>
- </dependency>
+ <groupId>org.apache.commons</groupId>
Review comment:
nit: please make sure they indentation does not change compared to the
other entries in the pom.xml file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
