rombert commented on a change in pull request #128: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/128#discussion_r826171461
########## File path: src/main/java/org/apache/sling/feature/cpconverter/handlers/IndexDefinitionsEntryHandler.java ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.sling.feature.cpconverter.handlers; + +import java.io.IOException; +import java.io.InputStream; +import java.util.Optional; + +import javax.jcr.RepositoryException; + +import org.apache.jackrabbit.util.Text; +import org.apache.jackrabbit.vault.fs.api.WorkspaceFilter; +import org.apache.jackrabbit.vault.fs.io.Archive; +import org.apache.jackrabbit.vault.fs.io.Archive.Entry; +import org.apache.jackrabbit.vault.fs.io.DocViewParser; +import org.apache.jackrabbit.vault.fs.io.DocViewParser.XmlParseException; +import org.apache.jackrabbit.vault.fs.io.DocViewParserHandler; +import org.apache.jackrabbit.vault.util.DocViewNode2; +import org.apache.jackrabbit.vault.util.PlatformNameFormat; +import org.apache.sling.feature.cpconverter.ContentPackage2FeatureModelConverter; +import org.apache.sling.feature.cpconverter.ConverterException; +import org.apache.sling.feature.cpconverter.index.IndexDefinitions; +import org.apache.sling.feature.cpconverter.index.IndexManager; +import org.jetbrains.annotations.NotNull; +import org.xml.sax.InputSource; + +/** + * Handler for Jackrabbit Oak index definitions + * + * <p>This implementation scans content packages for entries stored under <tt>/oak:index</tt> + * and exposes them to the {@link IndexManager} for further processing. + * + */ +public class IndexDefinitionsEntryHandler extends AbstractRegexEntryHandler { + + private final class IndexDefinitionsParserHandler implements DocViewParserHandler { + private final WorkspaceFilter filter; + private IndexDefinitions definitions; + + public IndexDefinitionsParserHandler(WorkspaceFilter filter, IndexDefinitions definitions) { + this.filter = filter; + this.definitions = definitions; + } + + @Override + public void startDocViewNode(@NotNull String nodePath, @NotNull DocViewNode2 docViewNode, + @NotNull Optional<DocViewNode2> parentDocViewNode, int line, int column) + throws IOException, RepositoryException { + + if ( nodePath.startsWith(IndexDefinitions.OAK_INDEX_PATH) && filter.contains(nodePath) ) { Review comment: Fixed in the latest push, we know support oak index definitions in the whole repository. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
