[
https://issues.apache.org/jira/browse/SLING-11158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508837#comment-17508837
]
Robert Munteanu commented on SLING-11158:
-----------------------------------------
Regarding the approaches to take - I think [~karlpauls] did the changes to make
it simpler to include extensions. Using a single jar is fine if all you want is
the stock feature launcher and we can use {{java -jar ... }}. But when you add
the content-package extension and maybe other extensions you get back to
building a complicated classpath and passing main classes, which not that nice.
Hence the launcher.
For the Starter part, I think it would be good to wrap the complexity in the
maven plugin. I am not sure if Karl plans to change back the way the feature
launcher works and make it 'batteries-included' again, but as soon as we need
to add a feature launcher extension for the Starter we'd hit the same problem.
So either we delegate to the launcher or we replicate it using the Maven plugin.
> The starter's "Start Sling" instructions don't work with feature launcher
> v1.1.28 or later
> ------------------------------------------------------------------------------------------
>
> Key: SLING-11158
> URL: https://issues.apache.org/jira/browse/SLING-11158
> Project: Sling
> Issue Type: Bug
> Affects Versions: Feature Model Launcher 1.1.28, Feature Model Launcher
> 1.2.0
> Reporter: Eric Norman
> Priority: Major
> Fix For: Feature Launcher Maven Plugin 0.1.4, Starter 13
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> After the SLING-10956 changes, launching the Starter with the README provided
> instructions while using the v1.1.28 or later feature launcher does not work
> anymore.
> For example,
> {noformat}
> $ java -jar target/dependency/org.apache.sling.feature.launcher.jar -f
> target/slingfeature-tmp/feature-oak_tar.json
> Error: Unable to initialize main class
> org.apache.sling.feature.launcher.impl.Main
> Caused by: java.lang.NoClassDefFoundError:
> org/apache/commons/cli/ParseException{noformat}
>
> Also, the start goal of the feature-launcher-maven-plugin fails with the same
> exception when paired with a featureLauncherVersion of 1.1.28 or later.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
