senn opened a new pull request #5: URL: https://github.com/apache/sling-org-apache-sling-commons-threads/pull/5
Exposed the info about cleanup operations using gauges so every threadpool has its own gauge. Another way to expose this info would be to use a `MetricsService.counter(...)` but I could only make this work by passing the bundleContext through several classes and that is not so elegant. About the other part of the ticket > log with a WARN level any cleanup operation. Care must be taken to not overflow the logs, so maybe a way of only reporting a cleanup for a certain key once can be used (memory-bound) I wasn't sure what "reporting a cleanup for **a certain key** once" meant. I added a WARN logging for every thread once, based on `Thread.getId()`, using an in-memory cache (Set) of processed threads, but I'm not sure that's OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
