rombert commented on code in PR #1: URL: https://github.com/apache/sling-org-apache-sling-commons-logservice/pull/1#discussion_r866933623
########## bnd.bnd: ########## @@ -0,0 +1,3 @@ +Import-Package: !java.lang, !java.util.*, * Review Comment: Please keep the Java package imports ( see my comment on https://github.com/apache/sling-org-apache-sling-serviceuser-webconsole/pull/1 ) ########## bnd.bnd: ########## @@ -0,0 +1,3 @@ +Import-Package: !java.lang, !java.util.*, * +Bundle-Activator: org.apache.sling.commons.logservice.internal.Activator Review Comment: It's less error-prone if you use an annotation, as exemplified at https://bnd.bndtools.org/chapters/230-manifest-annotations.html#arbitrary-manifest-headers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
