reschke commented on code in PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r871381196
##########
pom.xml:
##########
@@ -40,46 +39,28 @@
<connection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git</connection>
<developerConnection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git</developerConnection>
<url>https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-webdav.git</url>
+ <tag>HEAD</tag>
</scm>
<properties>
- <jackrabbit.version>2.14.2</jackrabbit.version>
+ <sling.java.version>8</sling.java.version>
+ <project.build.outputTimestamp>1</project.build.outputTimestamp>
+ <jackrabbit.version>2.14.3</jackrabbit.version>
Review Comment:
Exactly. So this project is ignoring these informations. It may be harmless
here, but is not harmless in general. IMHO there's absolutely no benefit in
being relaxed here; it's just giving users a bad example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
