cziegeler commented on code in PR #66:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/66#discussion_r879256061


##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##########
@@ -714,6 +783,17 @@ public void onChange(final List<ResourceChange> changes) {
                 continue;
             }
 
+            // during startup: just enqueue the events

Review Comment:
   It's maybe better to do the check at method start and then handle all 
changes in the same way. If the check is done here, the first changes might go 
into the queue, while the remaining ones are not.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to