jose-correia commented on code in PR #59:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/59#discussion_r887647886
##########
src/main/java/org/apache/sling/distribution/servlet/DistributionAgentServlet.java:
##########
@@ -71,7 +73,7 @@ protected void doPost(SlingHttpServletRequest request,
SlingHttpServletResponse
log.debug("distribution response : {}", distributionResponse);
} catch (Throwable e) {
log.error("an unexpected error has occurred", e);
- ServletJsonUtils.writeJson(response, 503, "an unexpected error
has occurred", null);
+ ServletJsonUtils.writeJson(response, 503, e.getMessage(),
null);
Review Comment:
@cschneider Its seems like implementing the error codes pattern you
mentioned is looking more and more useful. This could be solved by having
something like:
```java
public enum Error {
PACKAGE_SIZE(0, "Package size exceeds the limit threshold.", 400),
AUTHORIZATION(1, "Not authorized to perform action", 401);
INTERNAL_ERROR(2, "An error has occurred", 500);
....
}
public class DistributionException extends Exception {
public Error errorCode;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
