[
https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556445#comment-17556445
]
Eric Norman commented on SLING-11398:
-------------------------------------
[~olli] Can you please clarify if your comment means you are for or against the
proposed changes?
{quote}only some additional Groovy versions were released as fragments.
{quote}
Can you clarify what you mean by that? As far as I can tell, all the 2.x
groovy releases since 2.5 (plus the 3.x versions) have the ScriptEngineFactory
declared in the groovy-jsr223 fragment and no groovy-all uber bundle exists
anymore. Are you referring to groovy 4.x and later where groovy-jsr223 doesn't
appear to be a fragment anymore?
Perhaps, I should clarify that my primary motivation here is to resolve
SLING-11141 and that testing my solution to that issue revealed these findings:
# The ["groovy"
feature|https://github.com/apache/sling-org-apache-sling-starter/blob/master/src/main/features/groovy.json]
of the the starter contains the "org.codehaus.groovy:groovy-jsr223:3.0.9"
artifact. Why include that if it isn't going to be processed and used?
# The sling
[ScriptedHealhCheck|https://github.com/apache/sling-org-apache-sling-hc-support/blob/0612300a698b5d9ffa6132256ad0c8e0eae72aca/src/main/java/org/apache/sling/hc/support/impl/ScriptedHealthCheck.java#L85]
has a default config that declares "groovy" as the script language which
doesn't match what is provided by org.apache.sling.scripting.groovy
# Similary, the felix generalchecks
[ScriptedHealthCheck|https://github.com/apache/felix-dev/blob/eb99876e44791648939cb0fc7fdee22f00ed27b8/healthcheck/generalchecks/src/main/java/org/apache/felix/hc/generalchecks/ScriptedHealthCheck.java#L79]
has the same "groovy" language in the default config
> handle serviceloader ScriptEngineFactory defined in a fragment bundle
> ---------------------------------------------------------------------
>
> Key: SLING-11398
> URL: https://issues.apache.org/jira/browse/SLING-11398
> Project: Sling
> Issue Type: Bug
> Reporter: Eric Norman
> Assignee: Eric Norman
> Priority: Major
> Fix For: Scripting Core 2.4.10
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Handle loading of ScriptEngineFactory service loader
> (/META-INF/services/javax.script.ScriptEngineFactory) files that exist in a
> fragment.
> For example, consider the groovy ScriptEngine included in the starter that
> has these:
> Host Bundle - org.codehaus.groovy:groovy:3.0.9
> Fragment - org.codehaus.groovy:groovy-jsr223:3.0.9
>
> Expected:
> The groovy ScriptEngineFactory declared in the groovy-jsr223 fragment should
> be discovered and made available.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
