kwin commented on code in PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#discussion_r910947467
##########
src/main/java/org/apache/sling/discovery/base/commons/package-info.java:
##########
@@ -23,8 +23,7 @@
*
* @version 1.1.0
*/
-@Version("2.0.0")
+@Version("3.0.0")
Review Comment:
Switching annotations (from Bnd to OSGi only requires a micro(!) version
bump, i.e. 2.0.1 is totally fine.
##########
src/main/java/org/apache/sling/discovery/base/connectors/announcement/package-info.java:
##########
@@ -23,8 +23,7 @@
*
* @version 1.1.2
*/
-@Version("2.0.0")
+@Version("3.0.0")
Review Comment:
Switching annotations (from Bnd to OSGi only requires a micro(!) version
bump, i.e. 2.0.1 is totally fine.
##########
src/main/java/org/apache/sling/discovery/base/connectors/ping/wl/package-info.java:
##########
@@ -23,8 +23,7 @@
*
* @version 1.0.0
*/
-@Version("1.0.0")
+@Version("2.0.0")
Review Comment:
Switching annotations (from Bnd to OSGi only requires a micro(!) version
bump, i.e. 2.0.1 is totally fine.
##########
src/main/java/org/apache/sling/discovery/base/connectors/ping/package-info.java:
##########
@@ -23,8 +23,7 @@
*
* @version 1.0.0
*/
-@Version("1.0.0")
+@Version("2.0.0")
package org.apache.sling.discovery.base.connectors.ping;
-import aQute.bnd.annotation.Version;
-
+import org.osgi.annotation.versioning.Version;
Review Comment:
Switching annotations (from Bnd to OSGi only requires a micro(!) version
bump, i.e. 2.0.1 is totally fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
