kwin commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1171456991
The major version bump is not necessary due to the annotation type change, but due to backwards incompatible changes in `org.apache.sling.discovery.base.connectors.announcement.AnnouncementRegistryImpl` and `org.apache.sling.discovery.base.connectors.ping.ConnectorRegistryImpl`. The report (not the full one, but only the one containing the actual conflicts) exposes this: ``` [ERROR] * org.apache.sling.discovery.base.connectors.announcement PACKAGE MAJOR 2.0.1 2.0.0 3.0.0 - [ERROR] MAJOR PACKAGE org.apache.sling.discovery.base.connectors.announcement [ERROR] MAJOR CLASS org.apache.sling.discovery.base.connectors.announcement.AnnouncementRegistryImpl [ERROR] MICRO METHOD activate() [ERROR] REMOVED ANNOTATED org.apache.felix.scr.annotations.Activate [ERROR] ADDED ANNOTATED org.osgi.service.component.annotations.Activate [ERROR] REMOVED METHOD bindConfig(org.apache.sling.discovery.base.connectors.BaseConfig) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED RETURN void [ERROR] REMOVED METHOD bindResourceResolverFactory(org.apache.sling.api.resource.ResourceResolverFactory) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED RETURN void [ERROR] REMOVED METHOD bindSettingsService(org.apache.sling.settings.SlingSettingsService) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED RETURN void [ERROR] REMOVED METHOD unbindConfig(org.apache.sling.discovery.base.connectors.BaseConfig) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED RETURN void [ERROR] REMOVED METHOD unbindResourceResolverFactory(org.apache.sling.api.resource.ResourceResolverFactory) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED RETURN void [ERROR] REMOVED METHOD unbindSettingsService(org.apache.sling.settings.SlingSettingsService) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED RETURN void [ERROR] REMOVED ANNOTATED org.apache.felix.scr.annotations.Component [ERROR] REMOVED ANNOTATED org.apache.felix.scr.annotations.Service [ERROR] REMOVED PROPERTY value.0=org.apache.sling.discovery.base.connectors.announcement.AnnouncementRegistry [ERROR] ADDED ANNOTATED org.osgi.service.component.annotations.Component [ERROR] ADDED PROPERTY service.0=org.apache.sling.discovery.base.connectors.announcement.AnnouncementRegistry [ERROR] REMOVED ANNOTATED aQute.bnd.annotation.Version [ERROR] REMOVED PROPERTY value='2.0.0' [ERROR] ADDED ANNOTATED org.osgi.annotation.versioning.Version [ERROR] ADDED PROPERTY value='2.0.1' [ERROR] REMOVED VERSION 2.0.0 [ERROR] ADDED VERSION 2.0.1 [ERROR] * org.apache.sling.discovery.base.connectors.ping PACKAGE MAJOR 1.0.1 1.0.0 2.0.0 - [ERROR] MAJOR PACKAGE org.apache.sling.discovery.base.connectors.ping [ERROR] MAJOR CLASS org.apache.sling.discovery.base.connectors.ping.ConnectorRegistryImpl [ERROR] ADDED METHOD activate(org.osgi.framework.BundleContext) [ERROR] ADDED ACCESS protected [ERROR] ADDED ANNOTATED org.osgi.service.component.annotations.Activate [ERROR] ADDED RETURN void [ERROR] REMOVED METHOD activate(org.osgi.service.component.ComponentContext) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED ANNOTATED org.apache.felix.scr.annotations.Activate [ERROR] REMOVED RETURN void [ERROR] REMOVED METHOD bindAnnouncementRegistry(org.apache.sling.discovery.base.connectors.announcement.AnnouncementRegistry) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED RETURN void [ERROR] REMOVED METHOD bindConfig(org.apache.sling.discovery.base.connectors.BaseConfig) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED RETURN void [ERROR] MICRO METHOD deactivate() [ERROR] REMOVED ANNOTATED org.apache.felix.scr.annotations.Deactivate [ERROR] ADDED ANNOTATED org.osgi.service.component.annotations.Deactivate [ERROR] REMOVED METHOD unbindAnnouncementRegistry(org.apache.sling.discovery.base.connectors.announcement.AnnouncementRegistry) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED RETURN void [ERROR] REMOVED METHOD unbindConfig(org.apache.sling.discovery.base.connectors.BaseConfig) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED RETURN void [ERROR] REMOVED ANNOTATED org.apache.felix.scr.annotations.Component [ERROR] REMOVED ANNOTATED org.apache.felix.scr.annotations.Service [ERROR] REMOVED PROPERTY value.0=org.apache.sling.discovery.base.connectors.ping.ConnectorRegistry [ERROR] ADDED ANNOTATED org.osgi.service.component.annotations.Component [ERROR] ADDED PROPERTY service.0=org.apache.sling.discovery.base.connectors.ping.ConnectorRegistry [ERROR] MAJOR CLASS org.apache.sling.discovery.base.connectors.ping.TopologyConnectorServlet [ERROR] MICRO METHOD activate(org.osgi.service.component.ComponentContext) [ERROR] REMOVED ANNOTATED org.apache.felix.scr.annotations.Activate [ERROR] ADDED ANNOTATED org.osgi.service.component.annotations.Activate [ERROR] REMOVED METHOD bindAnnouncementRegistry(org.apache.sling.discovery.base.connectors.announcement.AnnouncementRegistry) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED RETURN void [ERROR] REMOVED METHOD bindClusterViewService(org.apache.sling.discovery.base.commons.ClusterViewService) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED RETURN void [ERROR] REMOVED METHOD bindConfig(org.apache.sling.discovery.base.connectors.BaseConfig) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED RETURN void [ERROR] REMOVED METHOD bindHttpService(org.osgi.service.http.HttpService) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED RETURN void [ERROR] MICRO METHOD deactivate() [ERROR] REMOVED ANNOTATED org.apache.felix.scr.annotations.Deactivate [ERROR] ADDED ANNOTATED org.osgi.service.component.annotations.Deactivate [ERROR] REMOVED METHOD unbindAnnouncementRegistry(org.apache.sling.discovery.base.connectors.announcement.AnnouncementRegistry) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED RETURN void [ERROR] REMOVED METHOD unbindClusterViewService(org.apache.sling.discovery.base.commons.ClusterViewService) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED RETURN void [ERROR] REMOVED METHOD unbindConfig(org.apache.sling.discovery.base.connectors.BaseConfig) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED RETURN void [ERROR] REMOVED METHOD unbindHttpService(org.osgi.service.http.HttpService) [ERROR] REMOVED ACCESS protected [ERROR] REMOVED RETURN void [ERROR] REMOVED ANNOTATED org.apache.felix.scr.annotations.Component [ERROR] REMOVED PROPERTY immediate=true [ERROR] REMOVED ANNOTATED org.apache.felix.scr.annotations.Service [ERROR] REMOVED PROPERTY value.0=org.apache.sling.discovery.base.connectors.ping.TopologyConnectorServlet [ERROR] ADDED ANNOTATED org.osgi.service.component.annotations.Component [ERROR] ADDED PROPERTY immediate=true [ERROR] ADDED PROPERTY service.0=org.apache.sling.discovery.base.connectors.ping.TopologyConnectorServlet [ERROR] REMOVED ANNOTATED aQute.bnd.annotation.Version [ERROR] REMOVED PROPERTY value='1.0.0' [ERROR] ADDED ANNOTATED org.osgi.annotation.versioning.Version [ERROR] ADDED PROPERTY value='1.0.1' [ERROR] REMOVED VERSION 1.0.0 [ERROR] ADDED VERSION 1.0.1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
