enapps-enorman commented on code in PR #24: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#discussion_r911494123
########## src/test/resources/testcases/test-40-output.txt: ########## @@ -1,3 +1,3 @@ RegisterNamespace (foo) uri:some-uri/V/1.0 RegisterNamespace (prefix_with-other.things) andSimpleURI -RegisterNamespace (foo2) uri:some-uri/V/1.1/test# +RegisterNamespace (foo2) uri:some-uri/V/1.1/test# Review Comment: The URI should be wrapped with quotes here in the output ########## src/test/resources/testcases/test-40.txt: ########## @@ -3,4 +3,4 @@ # and o.a.s.jcr.repoinit 1.0.2 register namespace (foo) uri:some-uri/V/1.0 register namespace ( prefix_with-other.things ) andSimpleURI -register namespace (foo2) uri:some-uri/V/1.1/test\# \ No newline at end of file +register namespace (foo2) "uri:some-uri/V/1.1/test\\#" Review Comment: Should not need to escape the hash character here since the quotableString() doesn't need it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
