[
https://issues.apache.org/jira/browse/SLING-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563578#comment-17563578
]
Carsten Ziegeler commented on SLING-11439:
------------------------------------------
If the implementation (Oak) decides to have a limit, I think that is fine and
must not result in propagating an exception when searching. In that sense, the
quoted code seems to do the right thing.
Whether catching throwable is the right thing, is a different topic :)
For vanity path queries it is actually crucial to get all results, but I think
the jcr resource implementation can't decide whether the call really needs all
results or is fine with a limited set. So I think, we need to introduce
something the caller can pass down in order to inform the (jcr) resource
implementation
> resource resolver: fails to detect aborted vanity path query
> ------------------------------------------------------------
>
> Key: SLING-11439
> URL: https://issues.apache.org/jira/browse/SLING-11439
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
> Reporter: Julian Reschke
> Priority: Major
>
> With the introduction of the Oak query limit, JCR queries may get aborted
> when the result set size exceeds a certain value (currently by default
> 100000).
> However:
> https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/604332e9be17378276685033bdbce54994dad8c1/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResourceIterator.java#L115-L134
> So Apache Sling JCR Resource's API hides that exception, and thus resource
> resolver will happily startup with an incomplete cache.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
