[
https://issues.apache.org/jira/browse/SLING-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563914#comment-17563914
]
Julian Reschke edited comment on SLING-11439 at 7/7/22 6:08 PM:
----------------------------------------------------------------
bq. Is there a real problem to be solved? My assumption is, this has been like
this for ages, so why change it now?
Has it been like that for ages? Didn't we just change the default setting a few
months ago? (Yes, I may be confused about this)
bq. For the vanity path/alias, isn't there an improvement in oak which will
allow us to do paged queries which then solves the problem?
Yes, but we still need to figure out (1) how to detect that this improvement is
present, (2) and select a proper page size. Paging by default will make things
more complicated; it would be much simpler to run the query as-is, detect that
it was aborted, and run a new query starting at the last location. (To make
things worse, we don't have a way to detect whether
https://issues.apache.org/jira/browse/OAK-9625 is supported at runtime)
(mumble - using the JCR API here would solve most of these issues)
was (Author: reschke):
bq. Is there a real problem to be solved? My assumption is, this has been like
this for ages, so why change it now?
Has it been like that for ages? Didn't we just change the default setting a few
months ago? (Yes, I may be confused about this)
bq. For the vanity path/alias, isn't there an improvement in oak which will
allow us to do paged queries which then solves the problem?
Yes, but we still need to figure out (1) how to detect that this improvement is
present, (2) and select a proper page size. Paging by default will make things
more complicated; it would be much simpler to run the query as-is, detect that
it was aborted, and run a new query starting at the last location. (To make
things worse, we don't have a way to detect whether
https://issues.apache.org/jira/browse/OAK-9625 is supported at runtime)
> resource resolver: fails to detect aborted vanity path query
> ------------------------------------------------------------
>
> Key: SLING-11439
> URL: https://issues.apache.org/jira/browse/SLING-11439
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
> Reporter: Julian Reschke
> Priority: Major
>
> With the introduction of the Oak query limit, JCR queries may get aborted
> when the result set size exceeds a certain value (currently by default
> 100000).
> However:
> https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/604332e9be17378276685033bdbce54994dad8c1/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResourceIterator.java#L115-L134
> So Apache Sling JCR Resource's API hides that exception, and thus resource
> resolver will happily startup with an incomplete cache.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
