stefan-egli commented on code in PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#discussion_r924663024
##########
src/main/java/org/apache/sling/discovery/base/commons/DefaultTopologyView.java:
##########
@@ -119,7 +119,7 @@ public Type compareTopology(final DefaultTopologyView
other) {
@Override
public boolean equals(final Object obj) {
- if (obj == null || !(obj instanceof DefaultTopologyView)) {
+ if (!(obj instanceof DefaultTopologyView)) {
Review Comment:
I see why this is identical to the previous code, but maybe it's just me,
for me the original code reads easier. I would prefer the original here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
