michalcukierman commented on code in PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-bundleresource-impl/pull/1#discussion_r934628061
##########
src/main/java/org/apache/sling/bundleresource/impl/BundleResource.java:
##########
@@ -229,7 +228,11 @@ public String getPath() {
@Override
public String getResourceType() {
- return this.valueMap.get(ResourceResolver.PROPERTY_RESOURCE_TYPE,
String.class);
+ String resourceType =
this.valueMap.get(ResourceResolver.PROPERTY_RESOURCE_TYPE, String.class);
+ if ( resourceType == null ) {
+ resourceType = this.isFolder ? NT_FOLDER : NT_FILE;
Review Comment:
The following implementation (local default resource types) seems to be
working (validated against WebSight):
```
@Override
public String getResourceType() {
String resourceType =
this.valueMap.get(ResourceResolver.PROPERTY_RESOURCE_TYPE, String.class);
if ( resourceType == null ) {
resourceType = this.isFolder ? "sling/bundle/folder" :
"sling/bundle/file";
}
return resourceType;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
