kwin commented on code in PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-bundleresource-impl/pull/1#discussion_r934793396
##########
src/test/java/org/apache/sling/bundleresource/impl/BundleResourceTest.java:
##########
@@ -111,7 +111,7 @@ void addContent(BundleResourceCache cache, String path,
String content) throws I
assertEquals(JcrConstants.NT_FILE, rsrc.getResourceType());
assertNull(rsrc.getResourceSuperType());
final ValueMap vm = rsrc.getValueMap();
- assertEquals(JcrConstants.NT_FILE,
vm.get(ResourceResolver.PROPERTY_RESOURCE_TYPE, String.class));
+ assertNull(vm.get(ResourceResolver.PROPERTY_RESOURCE_TYPE,
String.class));
assertEquals("foo", vm.get("test", String.class));
Review Comment:
Another test case for JSON resources would be nice, which asserts that
explicit "sling:property" keys from the JSON also appear in the value map.
@michalcukierman Can you extend an existing test or add a new one to cover that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
