kwin commented on code in PR #1: URL: https://github.com/apache/sling-org-apache-sling-bundleresource-impl/pull/1#discussion_r944275677
########## src/main/java/org/apache/sling/bundleresource/impl/PathMapping.java: ########## @@ -44,18 +46,20 @@ public static PathMapping[] getRoots(final String rootList) { final String resourceRoot = entry.getValue(); final String pathDirective = entry.getDirectiveValue(DIR_PATH); final String expandDirective = entry.getDirectiveValue(DIR_JSON); + final boolean skipSettingResourceTypeProperty = Boolean.parseBoolean(entry.getDirectiveValue(SKIP_SETTING_RESOURCE_TYPE_FLAG)); Review Comment: Maybe "hideResourceTypeProperties" is the better name (and an according constant name value). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org