michalcukierman commented on code in PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-bundleresource-impl/pull/1#discussion_r944634616
##########
src/main/java/org/apache/sling/bundleresource/impl/PathMapping.java:
##########
@@ -44,18 +46,20 @@ public static PathMapping[] getRoots(final String rootList)
{
final String resourceRoot = entry.getValue();
final String pathDirective = entry.getDirectiveValue(DIR_PATH);
final String expandDirective = entry.getDirectiveValue(DIR_JSON);
+ final boolean skipSettingResourceTypeProperty =
Boolean.parseBoolean(entry.getDirectiveValue(SKIP_SETTING_RESOURCE_TYPE_FLAG));
Review Comment:
It was proposed by @cziegeler in the [jira
comment](https://issues.apache.org/jira/browse/SLING-11504?focusedCommentId=17574690&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17574690)
I think that skipSettingResourceTypeProperty describes the actual flag
behavior. Hiding a property may be understood in different ways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
