joerghoh commented on code in PR #36:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/36#discussion_r964527580


##########
src/main/java/org/apache/sling/jcr/resource/internal/JcrValueMap.java:
##########
@@ -90,6 +90,10 @@ protected String checkKey(final String key) {
     @SuppressWarnings("unchecked")
     public <T> T get(final @NotNull String aKey, final @NotNull Class<T> type) 
{

Review Comment:
   the API docs does have the ```@NonNull``` annotation and it makes sense 
here. Here in this implementation it's misleading.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to