jsedding commented on code in PR #36:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/36#discussion_r964805992
##########
src/main/java/org/apache/sling/jcr/resource/internal/JcrValueMap.java:
##########
@@ -90,6 +90,10 @@ protected String checkKey(final String key) {
@SuppressWarnings("unchecked")
public <T> T get(final @NotNull String aKey, final @NotNull Class<T> type)
{
Review Comment:
My IDE complains when the annotations are present on the interface but not
on the implementation. I can see your POV, but in this case I would lean
strongly towards `@SuppressWarnings`. IMHO it's exactly a case like this where
adding this annotation documents that the "misimplementation" of the interface
is deliberate, and thus encourages interested future maintainers to dig through
commit messages and JIRAs in order to understand the rationale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
