malpani0311 commented on PR #62:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/62#issuecomment-1252169180
@tmaret
We can divide customers on 3 types based on naming convictions change[0] .
Before commit[0],
Customer already have errors queue and this customers will not be impacted
by this change.
After Commit[1],
Error queues started not getting automatically after agent creation due to
mismatch of variable names.
After this change ,
Agents will be created on activation through our implementation code[0]
which means error queue will also be created after installation.
>I think we are aligned, all existing deployment which configured error
queue with the current naming convention, would be affected by this change.
I want to understand how they will be impacted **by this change** because
currently they don't have error queue created at all.
> The agents that were created using this factory with the bug would not get
the errorQueue which is a bug. AFAIU, no existing configurations (faulty or
not) would not be affected by this change.
Agreed.
[0]:
https://github.com/apache/sling-org-apache-sling-distribution-core/blame/master/src/main/java/org/apache/sling/distribution/agent/impl/ForwardDistributionAgentFactory.java#L94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
