[ 
https://issues.apache.org/jira/browse/SLING-11589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dirk Rudolph updated SLING-11589:
---------------------------------
    Description: 
The ProcessorConfigurationImpl#match method currently checks the configured 
resourceType only on the requested resource [1]. This works as designed, 
however there are cases where a jcr:content child resource has a meaningful 
resourcetype for the rewriter and the requested resource does not. 

This is for example the case for AEM's cq:Pages. Requests usually are made for 
the cq:Page resource (resourceType being cq:Page) and not for the jcr:content.

A configuration should be made available to check the jcr:content as well 
(similar to unwrapResource).

 

[1] 
[https://github.com/apache/sling-org-apache-sling-rewriter/blob/7eb50dcd38e2e35ee597fa2e0b1fbfca0fe8b526/src/main/java/org/apache/sling/rewriter/impl/ProcessorConfigurationImpl.java#L435-L456]

  was:
The ProcessorConfigurationImpl#match method currently checks the configured 
resourceType only on the requested resource [1]. This works as designed, 
however there are cases where a jcr:content child resource has a meaningful 
resourcetype for the rewriter and requested resource does not. 

This is for example the case for AEM's cq:Pages. Requests usually are made for 
the cq:Page resource (resourceType being cq:Page) and not for the jcr:content.

A configuration should be made available to check the jcr:content as well 
(similar to unwrapResource).

 

[1] 
https://github.com/apache/sling-org-apache-sling-rewriter/blob/7eb50dcd38e2e35ee597fa2e0b1fbfca0fe8b526/src/main/java/org/apache/sling/rewriter/impl/ProcessorConfigurationImpl.java#L435-L456


> Processing pipeline with resourceType to check jcr:content as well
> ------------------------------------------------------------------
>
>                 Key: SLING-11589
>                 URL: https://issues.apache.org/jira/browse/SLING-11589
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Dirk Rudolph
>            Priority: Major
>             Fix For: Rewriter 1.3.4
>
>
> The ProcessorConfigurationImpl#match method currently checks the configured 
> resourceType only on the requested resource [1]. This works as designed, 
> however there are cases where a jcr:content child resource has a meaningful 
> resourcetype for the rewriter and the requested resource does not. 
> This is for example the case for AEM's cq:Pages. Requests usually are made 
> for the cq:Page resource (resourceType being cq:Page) and not for the 
> jcr:content.
> A configuration should be made available to check the jcr:content as well 
> (similar to unwrapResource).
>  
> [1] 
> [https://github.com/apache/sling-org-apache-sling-rewriter/blob/7eb50dcd38e2e35ee597fa2e0b1fbfca0fe8b526/src/main/java/org/apache/sling/rewriter/impl/ProcessorConfigurationImpl.java#L435-L456]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to