[ 
https://issues.apache.org/jira/browse/SLING-11396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17618918#comment-17618918
 ] 

Robert Munteanu commented on SLING-11396:
-----------------------------------------

[~kwin] - I prefer variant b), since we can hide more information behind 
{{nodeLabels}}. The current "branches" approach is only use for the Sling 
website, to make sure we are able to deploy - see 
https://github.com/apache/sling-site/blob/e9d4eae48709302dc70fa0740ce01d0fdee61e34/.sling-module.json#L5-L10
 .

Could we fail the build in case conflicting settings are detected - e.g. both 
branches and nodeLabels? I don't think we really need both, and if we end up 
with that need we can decide what to do at that time.

> Jenkins: Allow to configure build OS
> ------------------------------------
>
>                 Key: SLING-11396
>                 URL: https://issues.apache.org/jira/browse/SLING-11396
>             Project: Sling
>          Issue Type: Improvement
>          Components: Build and Source Control
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>
> As ASF provides Jenkins nodes for different operating systems 
> (https://cwiki.apache.org/confluence/display/INFRA/ci-builds.apache.org) we 
> should allow Sling modules to parameterize the OS as well.
> This requires an extension of 
> https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to