[
https://issues.apache.org/jira/browse/SLING-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu updated SLING-11722:
---------------------------------
Description:
The {{include}} method [0] has the following important sentence in its
documentation:
{quote}
The ServletResponse object has its path elements and parameters remain
unchanged from the caller's. The included servlet cannot change the response
status code or set headers; any attempt to make a change is ignored.
{quote}
However, the {{SlingRequestDispatcher}} [1] doesn't enforce this in any way.
[0] -
https://docs.oracle.com/javaee/7/api/javax/servlet/RequestDispatcher.html#include-javax.servlet.ServletRequest-javax.servlet.ServletResponse-
[1] -
https://github.com/apache/sling-org-apache-sling-engine/blob/bbc6acca70e7a27386f47fa9733af3740985f375/src/main/java/org/apache/sling/engine/impl/request/SlingRequestDispatcher.java#L177
was:
The {{include}} method [0] has the following important sentence in its
documentation:
{quote}
The ServletResponse object has its path elements and parameters remain
unchanged from the caller's. The included servlet cannot change the response
status code or set headers; any attempt to make a change is ignored.
{quote}
However, the {{SlingRequestDispatcher}} [1] doesn't enforce this in any way.
[0] -
https://docs.oracle.com/javaee/7/api/javax/servlet/RequestDispatcher.html#include-javax.servlet.ServletRequest-javax.servlet.ServletResponse-
> The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher
> API
> --------------------------------------------------------------------------------
>
> Key: SLING-11722
> URL: https://issues.apache.org/jira/browse/SLING-11722
> Project: Sling
> Issue Type: Bug
> Components: Engine
> Reporter: Radu Cotescu
> Assignee: Radu Cotescu
> Priority: Major
> Fix For: Engine 2.13.2
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The {{include}} method [0] has the following important sentence in its
> documentation:
> {quote}
> The ServletResponse object has its path elements and parameters remain
> unchanged from the caller's. The included servlet cannot change the response
> status code or set headers; any attempt to make a change is ignored.
> {quote}
> However, the {{SlingRequestDispatcher}} [1] doesn't enforce this in any way.
> [0] -
> https://docs.oracle.com/javaee/7/api/javax/servlet/RequestDispatcher.html#include-javax.servlet.ServletRequest-javax.servlet.ServletResponse-
> [1] -
> https://github.com/apache/sling-org-apache-sling-engine/blob/bbc6acca70e7a27386f47fa9733af3740985f375/src/main/java/org/apache/sling/engine/impl/request/SlingRequestDispatcher.java#L177
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
