kwin commented on code in PR #23:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#discussion_r1049384148
##########
src/main/java/org/apache/sling/jcr/repoinit/impl/RepositoryInitializerFactory.java:
##########
@@ -177,5 +192,10 @@ protected void applyOperations(Session session,
List<Operation> ops, String logM
}
}
+
+ protected boolean continueOnError() {
+ String failOnError = System.getProperty(PROPERTY_FAIL_ON_ERROR,"true");
Review Comment:
Let us please use the OSGi way in order to allow using framework properties
as well:
https://docs.osgi.org/javadoc/r4v43/core/org/osgi/framework/BundleContext.html#getProperty(java.lang.String)
##########
pom.xml:
##########
@@ -188,12 +188,12 @@
<artifactId>slf4j-api</artifactId>
<scope>provided</scope>
</dependency>
- <dependency>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-log4j12</artifactId>
- <version>1.7.30</version>
- <scope>test</scope>
- </dependency>
+ <dependency>
+ <groupId>ch.qos.logback</groupId>
Review Comment:
isn't slf4j-simple enough for the tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
