[
https://issues.apache.org/jira/browse/SLING-11739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649265#comment-17649265
]
Abhishek Garg commented on SLING-11739:
---------------------------------------
PR to fix that
[https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152]
cc : [~rombert] [~Sc0rpic0m]
> Index definition extraction from content packages is missing binary files data
> ------------------------------------------------------------------------------
>
> Key: SLING-11739
> URL: https://issues.apache.org/jira/browse/SLING-11739
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
> Affects Versions: Content-Package to Feature Model Converter 1.1.24
> Reporter: Abhishek Garg
> Priority: Major
>
> Currently, binaries are stored in indexDefinitions at [1] and these binaries
> should be written in JSONOutput at [2], However each time we are it. as empty
> at [2].
> The reason is that we are storing binaries against its repositoryPath instead
> it should be its parent path.
> i.e we are tika config.xml binaries at repositoryPath
> `oak:index/damAssetLucene-8-custom-2/tika/config.xml`
> and while writing at [2],we are trying to fetch it from
> `oak:index/damAssetLucene-8-custom-2/tika/`
> which is causing it empty as nodeName is till
> `oak:index/damAssetLucene-8-custom-2/tika` only.
> [1]:[https://github.com/niekraaijmakers/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/handlers/IndexDefinitionsEntryHandler.java]
> [2]:[https://github.com/niekraaijmakers/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java#L137]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
