kwin commented on code in PR #152:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#discussion_r1053268611
##########
src/main/java/org/apache/sling/feature/cpconverter/handlers/IndexDefinitionsEntryHandler.java:
##########
@@ -126,8 +126,9 @@ public void handle(@NotNull String path, @NotNull Archive
archive, @NotNull Entr
} else {
// binary file, should we attach?
- if (
archive.getMetaInf().getFilter().contains(repositoryPath)) {
-
indexManager.getIndexes().registerBinary(repositoryPath, is);
+ String binaryParentPath =
repositoryPath.substring(0,repositoryPath.lastIndexOf("/")) ;
+ if (
archive.getMetaInf().getFilter().contains(binaryParentPath)) {
+
indexManager.getIndexes().registerBinary(binaryParentPath, is);
Review Comment:
The javadoc says explicitly:
> repositoryPath The JCR repository path where the binary was found
This is for me the path to the binary node (nt:file)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
