On Wed, 2023-02-08 at 14:32 +0100, Konrad Windszus wrote:
> There is more work unfortunately. Also the implementation inside
> cp2fm needs to deal with the new statements.
> Maybe adding to the readme which version of repoinit language is
> supported is sufficient for now.

Create a PR, I will start work on the releases shortly, we don't need
the README updated within the release artifacts.

https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/156

Thanks,
Robert

> 
> > On 8. Feb 2023, at 14:17, Robert Munteanu <[email protected]>
> > wrote:
> > 
> > On Wed, 2023-02-08 at 12:15 +0100, Konrad Windszus wrote:
> > > IIUC then using the new repoinit statements will make the
> > > cpconverter
> > > throw an exception.
> > > That makes it pretty critical for me.
> > > Otherwise we should clearly indicate the non-compatibility with
> > > newer
> > > versions of repoinit somewhere.
> > 
> > Yes, that is my understanding as well. I don't think it's terribly
> > problematic to not support the new statements yet, as we can always
> > cut
> > a release later on.
> > 
> > If all that is needed is to get repoinit dependencies updated for
> > the
> > cpconverter, I can do that.
> > 
> > For more work I suggest we defer this to the next release.
> > 
> > Thanks,
> > Robert
> 

Reply via email to