Hi Eric,
thanks, good point. I'll cancel the vote and add some logging
Regards
Carsten
Am 13.02.2023 um 20:57 schrieb Eric Norman:
Carsten,
Perhaps it would be prudent to log a warning message when translations are
found outside of the included_paths or provide a HealthCheck component that
does the same?
Regards,
Eric
On Sun, Feb 12, 2023 at 12:52 AM Carsten Ziegeler <[email protected]>
wrote:
Hi,
yes, the default changes to provide a better out of the box setup.
I think we can handle this via documentation.
It is a change in behaviour but it is not breaking functionality - I
know that this is debatable and others might have a different view.
Most of the apps have their translations in /libs or /apps, there are
some exceptions. If you have translations outside the default and update
to the latest version *without* checking the changes, your application
will still work. It might not show you a translated UI, which is easily
detectable and then easy to fix.
Regards
Carsten
Am 11.02.2023 um 23:09 schrieb Eric Norman:
Hi Carsten,
For SLING-11744, what is the plan for dealing with backward
compatibility?
If I am reading the changes correctly, it looks like the
new JcrResourceBundleProvider "included_paths" config now has a default
value of {"/libs", "/apps"} so that is what you would get if no
configuration was provided for that field. That appears to replace the
previous behavior that would search the whole repository, so it doesn't
look backward compatible to me.
Regards,
Eric
On Sat, Feb 11, 2023 at 4:17 AM Carsten Ziegeler <[email protected]>
wrote:
Hi,
We solved 3 issues in this release
https://issues.apache.org/jira/browse/SLING-11744?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22i18n%202.6.0%22
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2717
You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
Usage:
sh check_staged_release.sh 2717 /tmp/sling-staging
Please vote to approve this release:
[ ] +1 Approve the release
[ ] 0 Don't care
[ ] -1 Don't release, because ...
This majority vote is open for at least 72 hours.
Regards
Carsten
--
Carsten Ziegeler
Adobe
[email protected]
--
Carsten Ziegeler
Adobe
[email protected]
--
Carsten Ziegeler
Adobe
[email protected]
