[
https://issues.apache.org/jira/browse/SLING-11728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695593#comment-17695593
]
Oliver Lietz commented on SLING-11728:
--------------------------------------
[~enorman], [~cziegeler], I merged the 3 PRs and now 2 tests are failing:
{noformat}
[ERROR] Failures:
[ERROR]
SLING10478IT.testCloseWriterErrorHandlerServlet:109->checkErrorHandlerServlet:124
[ERROR]
SLING10478IT.testNoCloseWriterErrorHandlerServlet:117->checkErrorHandlerServlet:124
[INFO]
[ERROR] Tests run: 15, Failures: 2, Errors: 0, Skipped: 0
{noformat}
There was quite some time between writing and merging the changes and some
changes to error handling happened in between.
Is the error reason obvious to you? Maybe in an updated dependency?
> Remove bi-directional dependencies between Engine and Servlets Resolver
> -----------------------------------------------------------------------
>
> Key: SLING-11728
> URL: https://issues.apache.org/jira/browse/SLING-11728
> Project: Sling
> Issue Type: Improvement
> Components: API, Engine, Servlets
> Affects Versions: Engine 2.12.0
> Reporter: Oliver Lietz
> Assignee: Oliver Lietz
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> *Situation*
> * bundle {{org.apache.sling.engine}} requires a {{ServletResolver}} which is
> provided by bundle {{org.apache.sling.servlets.resolver}}
> * bundle {{org.apache.sling.servlets.resolver}} depends on
> {{org.apache.sling.engine.servlets}} API
> The bi-directional dependencies between Engine and Servlets Resolver prevent
> the creation of meaningful and light deployment units (testing, features).
> *Options*
> # Merge {{org.apache.sling.engine}} and
> {{org.apache.sling.servlets.resolver}} into a single entity (bundle)
> # Move {{org.apache.sling.engine.servlets.ErrorHandler}} into Sling API
> (package {{org.apache.sling.api.servlets}}) and adjust usage in Servlets
> Resolver
> # Keep as is – leading to bigger, less manageable deployment units
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
