+0 for me. I don't have any blocking objections to this, just some nitpicks about the name.
Does adding the "Commons" prefix to the name add any value here? If I understand the approach correctly, then another bundle will contain a JCR (and/or Resource) specific implementation of the interface. Since this artifact appears to be just the service interface, perhaps "Apache Sling Permissions API" would be a more descriptive name for what is in there? Regards, Eric On Thu, Mar 9, 2023 at 8:30 AM Oliver Lietz <[email protected]> wrote: > Hi, > > We solved 2 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/123525564 > > This is the initial release of the API module: > https://github.com/apache/sling-org-apache-sling-commons-permissions > > And implementation module can be found here: > https://github.com/apache/sling-org-apache-sling-commons-permissions-sling > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2723 > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2723 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > O. > > > > >
